Design comparison
SolutionDesign
Solution retrospective
What do you think about using only rem units for easy scalability and about my solution in general?
Community feedback
- @CodeVeePosted over 2 years ago
Hi Pavlo. Fantastic job on this task. I also use rem for my responsiveness. I think it's good and less confusing than em. Few Suggestions
-
Wrap your code with a
main
tag to fix the landmark accessibility issue. -
Consider using a different element than the
ul
or use border-top and border-bottom for yourli
with padding rather thanhr
.
I hope you find this helpful
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord