Design comparison
SolutionDesign
Solution retrospective
Decided to knock out this one as well! These premium challenges are definitely a bit more challenging than others on their difficulty tier.
Community feedback
- @ApplePieGiraffePosted almost 3 years ago
Hey, Spencer Runde! 👋
Great job on this challenge! 👍Your solution matches the design very well and responds nicely! 😀I'd say this challenge can be slightly tricky to make responsive, but you nailed it! 🎉
Just a couple of small things I'd like to suggest,
- The "buttons" in this challenge look a lot like... well, buttons, but I think in the real-world they would more likely function as links (since they seem as if they would take you to another section on the page or another page altogether when clicked). I'd suggest turning those buttons into links (but keeping the same styling of course) to reflect how they might actually be used in a full-fledged site.
- Adding
cursor: pointer
to the buttons would be a nice touch (but that style should be added automatically if you change the buttons to links). - I don't think you need to add
aria-hidden: true
to images if you set theiralt
attribute to an empty string. Screen readers will already ignore images that have emptyalt
text.
I hope those few (small) tips are helpful. 🙂
Keep coding (and happy coding, too)! 😁
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord