Mobile-first landing page using Flexbox, Grid and SASS

Community feedback

• 

  Rosi•440

  @strosiPosted almost 3 years ago

  Hi Davide. You've created the underlining of "Learn more" as linear background half of it transparent and the lower part of it with color (yellow or red). This way the roundness of the upper corners will never be visible because the corners are not visible itself. Try useing pseudo elements to implement this decoration - something like this.

  Marked as helpful

  1

  ---

  

  Davide Tarpini•110

  @SparkhandPosted almost 3 years ago

  @strosi this is a really precious piece of advice, thanks a lot! I'm not used to working with pseudo-elements, but that's definitely something I'd better cover

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Davide Good Job on challenge

  -> Always use h1 first and then h2, h3 and so on

  -> Check my article on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  1

  ---

  

  Davide Tarpini•110

  @SparkhandPosted almost 3 years ago

  @Crazimonk looking forward to reading your article, thank you so much :)

  1
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man.

  1