Mobile-First Fylo landpage, with responsive layout using CSS.
Design comparison
Solution retrospective
I personally think I did a good job in this challenge, but I'm also open for feedbacks, improvment tips and best practices. I think I could've used a little bit less of code in styling the desktop layout, and I'll try to improve that, since this is my first coding using the mobile-first approach, so I'll try to use the right properties when coding the basic layout so I have to change less things on the media queries. Thanks :}
Community feedback
- @SamadeenPosted over 2 years ago
Hey!! Cheers 🥂 on completing this challenge.. .
Here are my suggestions..
- You should use <main class="container"> instead of <div class="container">.
- Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
- You should include text in your anchor tag.
- Always nest your headings and paragragh in a div or section
This should fix most of your accessibility issues
. Regardless you did amazing... hope you find this useful... Happy coding!!!
Marked as helpful1 - @Kamasah-DicksonPosted over 2 years ago
- I love the fact that you started mobile first.
- Your accessibility issues are pretty basic and understandable, you must probably look through.
Besides great solution there👍 Happy coding👍💻
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord