mobile-first flex feature-section

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi, this looks pretty nice (viewing on mobile)....

  Maybe adjust the heading font sizes a little as they look a bit off from the design. They're a little similar in size so it's losing that perceived sense of content hierarchy.

  Remember you can't have two h1s on a page. For this, I'd probable have one h1 but use classes on spans inside to style the two parts of the h1.

  Also be careful with css ordering. At the moment, you're loading your reset after your own styles because of the order in the html head. You're also downloading two css resources which is bad for performance. I recommend copying or importing resets into your css file at the very top and only loading up one css asset in the html.

  I hope that's helpful to you. Keep on coding

  1

  ---

  

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  ps. How you've done this with flex is fine, but this challenge is ideal practicing ground for css grid. I recommend if you have time to create a branch or fork the repo where you use grid for layout instead

  1

  

  Rogelio•45

  @rogedevPosted almost 4 years ago

  @grace-snow thanks for reviewing my code, appreciate that. I will keep learning😎

  0