Mobile-first chat app illustration

Community feedback

• 

  T

  Alex•2,010

  @AlexKMarshallPosted about 3 years ago

  This looks great, it's nicely responsive, there's really only a couple of points I have.

  For the heading and body text, they really should be in rem, not in px, so they scale with a user's chosen base size.

  Normally I'd avoid fixed container sizes too, but as they're only on the phone illustration, and this really behaves more like a fixed image than a regular piece of content, I think it's fine.

  I would maybe put aria-hidden on the phone container so that it isn't read out by screen-readers. I think otherwise the page would read fairly confusingly. Also, you've got img elements in there with a missing alt property. <img alt/> isn't valid, it needs to be <img alt=""/> or better still, a proper descriptive value. Though if you hide that whole block it will be fine. But it's a good habit to get into checking the alt texts are correct.

  Marked as helpful

  0