Mobile-first Attempt with plain CSS

Community feedback

• 

  T

  Grace•30,990

  @grace-snowPosted almost 4 years ago

  Hi Peter

  This looks good, you should be pleased with it.

  A few suggestions for you:

  • spans shouldn't sit on their own, they need to be inside other elements, like paragraphs if you're writing text
  • your js could be simpler by toggling a single class on a parent element like the bottom container to indicate whether the share is open or not. The rest is handled in css, so no need for a separate active/hidden class on each item you want to change
  • I would wrap those social icons in labelled link tags (anchor tags)

  Nice layout overall, like the transitions and its all well written and well structured on the whole. Nice one 👍

  1