Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile-First Application Developed with HTML, CSS and JavaScript

Stefania-P11β€’ 30

@Stefania-P11

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please let me know if my code follows the best practices! I am looking forward to any kind of feedback!

Thank you,

Stefania

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • The <div class=attribution> want to be placed outside the main element, because it meant to be a footer element

    • And don't forget to use semantic elements such as <footer> for <div class="attribution"> to improve accessibility and organization of your page.

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

0

Stefania-P11β€’ 30

@Stefania-P11

Posted

@0xAbdulKhalid Hey Abdul! Thank you so much for your recommendation! You are absolutely right in regards to the .attribution class being a footer. I need to pay more attention to how I organize my code within the main, header and footer sections -- I don't usually use them and noticed that more experience devs do that.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord