Mobile-First Application Developed with HTML, CSS and JavaScript
Design comparison
Solution retrospective
Please let me know if my code follows the best practices! I am looking forward to any kind of feedback!
Thank you,
Stefania
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
-
The
<div class=attribution>
want to be placed outside themain
element, because it meant to be afooter
element- And don't forget to use semantic elements such as
<footer>
for<div class="attribution">
to improve accessibility and organization of your page.
- And don't forget to use semantic elements such as
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
0@Stefania-P11Posted over 1 year ago@0xAbdulKhalid Hey Abdul! Thank you so much for your recommendation! You are absolutely right in regards to the .attribution class being a footer. I need to pay more attention to how I organize my code within the main, header and footer sections -- I don't usually use them and noticed that more experience devs do that.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord