Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile UI for a NFT Preview Card

Richard 140

@RixCrafts

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <h2> with <h1> to fix the accessibility issues.

To center the main on the page using flexbox, replace the height in the body with min-height: 100vh.

There is no need to give the main a height value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

Richard 140

@RixCrafts

Posted

@Hassiai Thanks for the feedback..

One question: The height of the main if not assigned will be automatically taken from the height of all the children right?? Is that a better practice than assigning a height to the main from the beginning ? Or it becomes redundant?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord