Mobile UI for a NFT Preview Card

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <h2> with <h1> to fix the accessibility issues.

  To center the main on the page using flexbox, replace the height in the body with min-height: 100vh.

  There is no need to give the main a height value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Richard•140

  @RixCraftsPosted almost 2 years ago

  @Hassiai Thanks for the feedback..

  One question: The height of the main if not assigned will be automatically taken from the height of all the children right?? Is that a better practice than assigning a height to the main from the beginning ? Or it becomes redundant?

  0