Skip to content
Submitted 10 months ago

Mobile QR code Component

Danidiv•130
@Danidiv
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted 10 months ago

    Hello there 👋. Good job on completing the challenge !

    I have some suggestions about your code that might interest you.

    • The <div class="container"> tag shouldn't have a min-height: 85vh. This causes the card to elongate too much on mobile devices. Instead, the <body> tag should have a min-height: 100vh to ensure its element is centered correctly.
    • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord