Mobile layout first, SCSS, BEM methodology

Community feedback

• 

  Khalis•135

  @khalisabrahmanPosted over 3 years ago

  Thank you so much for taking the time to provide the feedback!

  Will put in place the recommendations in the project.👍

  1
• 

  MasterKrab•940

  @MasterKrabPosted over 3 years ago

  Great job on this challenge!

  I have a couple of recommendations:

  • The input should have a valid accessibility name, such as a label with a for attribute or an aria-label. Also since it is a field for the email it should have type="email".

  <label for="email">Email</label>
  <input type="email" id="email">
  
  <-- Or --->
  
  <input type="email" aria-label="email">
  

  • The section and article should have a title (h1-h6), or you can use an aria-label as well.

  <article>
   <h2>Title</h2>
   <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. </p>
  </article>
  
  <-- Or -->
  
  <article aria-label="Title">
   <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. </p>
  </article>
  

  0