Design comparison
Solution retrospective
Good experience. Good challenge!! Desktop layout was made in one day. But it took 2 days more for mobile layout. I didn`t even hear before about @media. I used it for the first time. Also I had some troubles with borders radius in mobile version. Finally solve it. But it was not easy.
Community feedback
- @VCaramesPosted about 2 years ago
Hey @Masunsa, some suggestions to improve you code:
- To center you content to your page, add the following to your Body Element:
body { min-height: 100vh; display: grid; place-content: center ; }
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
Happy Coding! 👻🎃
0 - @Oussous-AbdelhadiPosted about 2 years ago
Hey Marat its a nice project, keep moving forward
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord