Design comparison
Community feedback
- @D3press3ddPosted almost 3 years ago
Hi, just a few things -Dont use a static 85vh to the height because if i have a 4k screen, it will looks really weird, like this Preview
-remember that if you add
flex
orgrid
the first level of childrens well be affect, the level 2 children not, so youre aplying flex to thecontainer
instead of the divcard
for that reason the content overflow it, look Preview-remember that you need to add the desktop version , if youre a little bit confuse maybe check some solutions on the community, you can check my solution too and thats it
happy coding, if you have doubts, you can write me without problem💞💞
Marked as helpful1@Babray03Posted almost 3 years ago@D3press3dd Hey, thanks I really appreciate the feedback. I had no idea that VH was a static property. Also I am still getting used to inheritance and the children elements but I will look into it to learn more about it, thanks for pointing that out.
0@D3press3ddPosted almost 3 years ago@Babray03 vh it's not static, the problem is that you're using 85% of the viewport high that means it will use 85% of the height depending of the screen size that you're using, so if im using a screen with 4k it will take 85% of the 4k height, take a look to this small video, is very interesting short about viewport units
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord