@Stroudy
Posted
Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…
- Overusing
<div>tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like<header>,<section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.
<div class="main-container">
<div class="qr-container">
<img src="images/image-qr-code.png" alt="qr-code" class="qr-code-img">
</div>
<div class="text-container">
<div class="top-text">Improve your front-end skills by building projects</div>
<div class="bottom-text">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</div>
</div>
</div>
- Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.
<div class="main-container">
-
For future project, You could download and host your own fonts using
@font-faceimproves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts -
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,
-
Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like
1.5for flexibility. Avoid using fixed units likepxor%, as they don't adapt well to changes in font size or layout. -
While
pxis useful for precise, fixed sizing, such asborder-width,border-radius,inline-padding, and<img>sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, usingpxfor font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units likeremand adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Usepxwhere exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
Marked as helpful
@Stroudy Thank you so much for your feedback. Gonna check out all the things you linked and gotta work on using proper semantics in my future projects!
@Stroudy
Posted
Hey @Dzik0, No problem, You got this!
