Mobile firste QR Code Component made with HTML and SCSS

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Great job in completing this project. Viewing your solution, I think you should considered the following as well...

  • Add color to the p in .qrcode__description as color: hsla(227, 10%, 71%, 1);
  • Import the attribution style in the CSS file and remove style tag
  • Wrap qrcode with specific tag like main and attribution with footer tag for readability. For HTML structure, refer it to this one Semantics

  Overall you did well and Keep up the good work!

  Marked as helpful

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job you made it look nearly perfect to the preview

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  Keep up the good work!

  Marked as helpful

  1