Submitted almost 3 years ago
Mobile firste QR Code Component made with HTML and SCSS
@thomasjonstrup
Design comparison
SolutionDesign
Community feedback
- @RioCantrePosted almost 3 years ago
Hello there! Great job in completing this project. Viewing your solution, I think you should considered the following as well...
- Add color to the
p
in.qrcode__description
ascolor: hsla(227, 10%, 71%, 1);
- Import the
attribution
style in the CSS file and removestyle
tag - Wrap
qrcode
with specific tag likemain
andattribution
withfooter
tag for readability. For HTML structure, refer it to this one Semantics
Overall you did well and Keep up the good work!
Marked as helpful1 - Add color to the
- @NaveenGumastePosted almost 3 years ago
Hay ! Good Job you made it look nearly perfect to the preview
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body like it should be your container
-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc
-> But use header tag only once in main heading element.
Keep up the good work!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord