Mobile first Workflow, CSS Flexbox, Vanilla JS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hey this looks really good.

  Only minor suggestions from me ☺

  • the logo is the most important info on the page but it's currently hidden from assistive technology because of the empty alt attribute
  • it's best practice to link the input to the id of its error message with aria-desciribedby
  • add aria-live="polite" to the error so it gets announced by screenreaders when it appears
  • in js try to use consistent selectors. I like to follow the Airbnb style and use js-prefixed classes for things I need to select in js. Your choice though really
  • in js, it would be better if you toggled a class on the input and used that to add error styles in your css. It's good to keep a separation of concerns, with all styling handled by css rather than adding inline styles. Js would be shorter that way too.

  Well done again and keep going with your learning 👍

  2

  ---

  

  Gilang Aditya•425

  @madegilangadityaPosted over 3 years ago

  @grace-snow Thanks for your feedback Grace. Very apreciated..

  0