Mobile first with scss and BEM

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi there, Tim Leonard! 👋

  Good effort on this challenge! 👍 Kudos for trying out BEM (it really is a nice idea that makes naming classes much easier, IMHO). 😅

  If you'd like to work on getting your solutions closer to the original design, check out this browser extension called PerfectPixel. It allows you to overlay images (such as the design JPGs that come with the free starter files for Frontend Mentor challenges, in this case) over your website so that you can see exactly how what you're building lines up with the original design. It's just helpful as a guide, however—don't feel the need to get everything so exact (i.e., "pixel perfect") if you don't want to. 😉

  Keep coding (and happy coding, too)! 😁

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Good work on that one and especially to your BEM, now try using BEM in a way that you can resuse every blocks of it, it might be hard at first but practicing on that will help anyone especially on a large code bases right. Also your hamburger buttons, I see that you remove the border so that when it is clicked no square right, but it seems it doesn't do the work. What you could do is add this in your button, or buttons to remove the border outline: none outline and border are two different properties. Also a tip hehe if you use figma or adobe xd, to properly resize your component, first, check the dimension of the design that you take. If it is 1440 x 900, then make your page in either figma, xd or any other software, to have the page 1440px width and 900px height so that you could make pixel perfect^

  0