Skip to content
Submitted 10 months ago

Mobile first with responsive units in CSS

hashiharisā€¢100
@hashiharis
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi all,

  • I am a newbie and have submitted a newbie challenge. I build a mobile first design. However when I did the responsiveness for desktop at 1440px as the style guide of this challenge recommended. I feel it might break in desktop view. Please feel free to provide your valuable feedback on responsiveness in css for desktop views.

Community feedback

  • Daniel šŸ›øā€¢44,250
    @danielmrz-devPosted 10 months ago

    Hello @hashiharis!

    Your solution looks great!

    I have a suggestion for improvement:

    • For semantic reasons, use <main> to wrap the main content instead of a <div>.

    šŸ“Œ This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord