Skip to content
Submitted over 3 years ago

Mobile First With HTML, SCSS and JS

asadali209•115
@asadali209
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This project took me 2 days to complete. Most of my time was consumed due to positioned elements as I am not very good at that. So I would highly appreciate if you guys can give me feedback and also what can I do to improve it. Regards.

Community feedback

  • Jaspal Singh•105
    @JaspalSingh1998Posted over 3 years ago

    hi @asadali209 adding to Asif's suggestion i would like to say that it would be nice if you can attach the event listener on the whole li part rather than just on the arrow part. Because it will enhance the user experience if you put event listener on the whole li as it will give user more area to click. just a suggestion 😁. Other than that good work mate. Happy Coding 😊

    0
    asadali209•115
    @asadali209Posted over 3 years ago

    @JaspalSingh1998 Thank you. I will definitely change the event listener to whole li.

    1
  • Asif M•200
    @asifm37Posted over 3 years ago

    Hi asadali209, Initially, even I struggled with positioning. My suggestion would be to use flex or grid in CSS. And also I learned that it's better to use bg-images in CSS-background. Hope this helps.

    0
    asadali209•115
    @asadali209Posted over 3 years ago

    @asifm37 Thank you for your suggestions. I will try to learn more about grid.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord