Mobile first website using scss and bem

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Greetings TiredQuan

  • notably missing in your html structure are semantic html elements like header, main etc. Where possible avoid using the div if there is a more suitable element.
  • a site has to have at most one h1 element - which points me back to the issue I mentioned above. One of the div must be an h1

  Happy coding

  Marked as helpful

  1
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  your issue is at the point where your mobile layout becomes your desktop half your desktop layout ends up outside the browser window. This challenge works good with a middle transition of 2 columns with 2 cards. This is easy to do using grid template areas to be able to rearrange cards with a few lines of code

  Marked as helpful

  1

  ---

  

  TiredQuan•245

  @TiredQuanPosted over 3 years ago

  @palgramming I just changed the flexbox I used in the cards to grid and added another media query for 1200px

  Thanks a thousand btw, I wouldn't know if I was wrong if it wasn't for you!

  1

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @TiredQuan No problem glad I was able to help

  0