Mobile first website using HTML, CSS, JS, BEM

Community feedback

• 

  Davide•1,725

  @Da-vi-dePosted over 3 years ago

  Hi Cassia, it's a good result for this challenge, full responsive, great!

  • I can understand your code, it's well indented i would add area comments, (i can't right the html comments in here it doesn't show it, i don't know why, but i guess you got it), so that i know what is what.

  • I spotted the missing heading after section element, unfortunately this is the rule, use it only when there's an heading right after. You started a section and then you have a bunch of div, for the cards info content i would use an article in order to highlight important content. The article is semantic and it's perfect because it must be followed by a heading, you have ah2 followed by p tag.

  Hope it helps a little, happy coding :-)

  Marked as helpful

  1

  ---

  

  Cássia•90

  @casbernPosted over 3 years ago

  Hi @Da-vi-de! Thank you very much for your comment. I really appreciated. I am still struggling to learn how to deal with semantics. I have a question.. You meant I need to have a heading tag after the tag? Every time I use a tag I should use also a heading tag? That is a bit fuzzy to me...

  I think the part I understood and I will implement that for sure. =)

  So... every time I use either a or both need to be follow just after the opening tags by a heading tag? Is that it? Did I get it correct?

  1

  

  Davide•1,725

  @Da-vi-dePosted about 3 years ago

  @cah90 Yeah, you got it right i make an example:

            <article class="">
                 <h2></h2>  
                  <p></p>
                  <p></p>
                  <p></p>
                  <p></p>
                  <p></p>
              </article>
  

  As you can see the heading comes right after the opening tag. You use article when you have a block of content, same goes for section, you shouldn't open a div after the tag. The first tag must be a heading then you can open div and do what you need to do, it's just about the first tag!

  1

  

  Cássia•90

  @casbernPosted about 3 years ago

  @Da-vi-de Ah.. I understood now! Thank you for your explanation. =) I just learned a new thing and I will apply it from now on. Have a great day!

  1