Not Found
Not Found
Not Found
Request path contains unescaped characters
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first website using HTML, CSS, JS, BEM

Cássia 90

@casbern

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, guys!

I would like to know if my code is easy to understand. If you need to refactor my code, for example, can you easily understand it? If not, how do you think I can improve it?

Please, any constructive comment is really welcome!

Community feedback

Davide 1,725

@Da-vi-de

Posted

Hi Cassia, it's a good result for this challenge, full responsive, great!

  • I can understand your code, it's well indented i would add area comments, (i can't right the html comments in here it doesn't show it, i don't know why, but i guess you got it), so that i know what is what.

  • I spotted the missing heading after section element, unfortunately this is the rule, use it only when there's an heading right after. You started a section and then you have a bunch of div, for the cards info content i would use an article in order to highlight important content. The article is semantic and it's perfect because it must be followed by a heading, you have ah2 followed by p tag.

Hope it helps a little, happy coding :-)

Marked as helpful

1

Cássia 90

@casbern

Posted

Hi @Da-vi-de! Thank you very much for your comment. I really appreciated. I am still struggling to learn how to deal with semantics. I have a question.. You meant I need to have a heading tag after the tag? Every time I use a tag I should use also a heading tag? That is a bit fuzzy to me...

I think the part I understood and I will implement that for sure. =)

So... every time I use either a or both need to be follow just after the opening tags by a heading tag? Is that it? Did I get it correct?

1
Davide 1,725

@Da-vi-de

Posted

@cah90 Yeah, you got it right i make an example:

          <article class="">
               <h2></h2>  
                <p></p>
                <p></p>
                <p></p>
                <p></p>
                <p></p>
            </article>

As you can see the heading comes right after the opening tag. You use article when you have a block of content, same goes for section, you shouldn't open a div after the tag. The first tag must be a heading then you can open div and do what you need to do, it's just about the first tag!

1
Cássia 90

@casbern

Posted

@Da-vi-de Ah.. I understood now! Thank you for your explanation. =) I just learned a new thing and I will apply it from now on. Have a great day!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord