Design comparison
Solution retrospective
Hello everybody!
Any feedback is welcome!
Community feedback
- @dwhensonPosted almost 4 years ago
Great job and lovely screenshot that matches the design well!
A few points to think about...
-
In the HTML you would want to include a label element and a name attribute on the input elements to help screen readers - if you don't want to show the label element in your design you can make it only visible to screen readers. A quick google will give you some standard code to enable this.
-
In the JS you might want to consider removing the error styles once the form is valid? You could do this by adding a 'keydown' event listener to the input once the form is submitted. This would help let the user know that they can now submit the form as the email is valid.
Great stuff though - looks great!
1@SamyrORPosted almost 4 years agoOh, thanks @dwhenson!
This is very useful, i'll look it up!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord