Design comparison
Solution retrospective
Any feedback would be appreciated! Strayed away from the design just a bit so that the background svg would tile nicely at views outside of the given mobile/desktop. Also, changed the error messages from given design to be more detailed for email/password validation.
Community feedback
- @dmitrymitenkoffPosted about 3 years ago
Hi Ryan, Great job on designing the form and making it responsive. I also liked how you went about implementing form field validation. One thing you may want to look into is adding labels to each input, as these should always accompany their respective input fields. Here's what MDN says specifically about the label element: "All elements within a form must have a
<label>
that identifies its purpose. This applies to all types of <input> items, as well as<button>
,<output>
,<select>
,<textarea>
,<progress>
and<meter>
elements, as well as any element with the switch ARIA role." MDN.On the other hand, I realise the design doesn't want visible labels present. In this case, you can visually hide labels from users but not from assistive technologies. Here's a useful article on CSS-Tricks that will guide you through the implementation of the technique: HTML Inputs and Labels: A Love Story.
Hope this is helpful.
Keep up the great work!
Cheers
Marked as helpful0@ryancalacsanPosted about 3 years ago@dmitrymitenkoff Thanks so much for the feedback! I will definitely take a look into the article and make the changes. I am trying to research and get better with accessibility and this is super helpful!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord