Design comparison
Solution retrospective
Hi! This is my second challenge. Still slower but getting better. :)
My first try in mobile first approach. I find it easier as I still get confused with media queries. Is it advisable to use this workflow everytime or are there instances that I should not to?
I don't understand why the desktop background image on the github pages not showing but it does when I open the liveserver.
Any feedback is greatly appreciated so I can keep improving. Thanks.
Community feedback
- @nicm42Posted over 3 years ago
This looks great.
There are debates on the internet about whether you should code mobile-first or desktop-first. Different people find different ways round easier to understand or mean writing less code. So you can do whatever approach you feel works for the thing you're coding.
I looked at your background-image problem for a while trying to work out what's different between the mobile and desktop ones. Once I spotted it, it's obvious! The mobile one you have quotes around the url, which isn't on the mobile one, but that makes no difference. What does make a difference is that the desktop one has / at the start of the link, so it's trying to find it in https://chawissa.github.io/images/bg-intro-desktop.png - it's missing the signup-form folder in the link. If you get rid of the / the background image will show up.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord