Hi @stevenabaco you did very well on the challenge 👏👏. I have a few recommendations for you:
- Instead of
background-size: initial, you can have something likebackground-size:100vw 40vh`. - Look into relative units, using rem/ems enables users to resize fonts and sizes from their browsers.
Happy coding!
Marked as helpful
1
Steven Abaco• 65
@stevenabaco
Posted
@jmnyarega Thanks for your feedback.
Yes, I could have used the view port sizes but I decided to use 'initial' option since the original background svg had the fixed size I wanted to maintain as the max width even on larger screens. I didn't want the image being stretched passed that max size.
I use the 100vh option for the height all the time for landing pages which need to fill the entire screen on load.
Happy coding!
0
