Mobile first using flexbox for main sections and grid for footer

Community feedback

• 

  Anna Leigh•5,135

  @brasspetalsPosted over 3 years ago

  Hi again, Steve!

  Your solution looks good for the widths that you did, but I hope you come back to this challenge at some point to do the "medium"/tablet layout. Not having a design to work off of can be tricky, but is a great challenge and a good way to practice responsiveness. Grid is definitely worth learning - glad to see you starting to use it! 👍 I wish I had for this challenge.

  Anyway, just a few, small suggestions:

  • To clear up the errors in the report, remove the name and id from the email input (since they have been left blank), and add a label.
  • The header navigation items should be links (simply wrap the text inside your li’s in anchor tags), as should “See how Fylo works” and the social icons in the footer.

  Looking forward to your next solution - happy coding!

  0

  ---

  

  Stephen Tyers•235

  @stephentyers1975Posted over 3 years ago

  @brasspetals Thanks for the comments. I agree with everything you said. My plan is to run through all the HTML/CSS challenges first and get them more or less right per the designs. As a complete beginner, I'm learning as I go along, so once I finish all these challenges, I'll go back and improve based on people's feedback.

  0