Hey @SJ-74 👋🏻
I have some suggestions for the project.
- For the icons, add
aria-hidden="true”
, because they are for decoration. You can read more aboutaria-hidden
here. For example:
<img src="images/icon-supervisor.svg" alt="" aria-hidden="true”>
And in general in alt
tags avoid using words like logo
, illustration
, etc. They become redundant for the user who uses a screen reader.
- Nice touch on
:hover
effects, but I suggest addingtransition: all 0.2s;
to the button and the links, this will make:hover
smoother. - Lastly, I suggest increasing the header
font-size
from1.5rem
to2.5rem
.
I hope this was helpful 👨🏻💻 all in all, you did a great job, and there's no proper way to do it. As long as you write a maintainable code, everything can be the proper way here. Cheers 👾
Marked as helpful