What are you most proud of, and what would you do differently next time?
I used SCSS for the first time in any FEM challenge and would like to improve my SCSS knowledge as of now.
What challenges did you encounter, and how did you overcome them?
Nothing much as this was very beginner friendly challenge and I have already completed few challenges before this.
What specific areas of your project would you like help with?
Would appreciate feedback on use of SCSS.
@minimalsm
Posted
Looking good @SJ-74 💪!
Few suggestions to get it closer to the original design:
font-size should be bigger (1.375rem)This looks good. Try to tweak the shadow a tiny bit more, and looks like yours has a bit more space between the end of the writing and the bottom of the card.
Are you trying to use BEM naming on this? There’s one class that veers off by having two sets of elements (proceeded with the double underscore). Text-section would be better there
When writing scss I recommend against nesting part names like that. It is completely valid as an approach (I did that for years) but when you work on big projects, the scss becomes unweildy, hard to read and hard to debug. Nowadays it’s generally recognised that it’s only good to nest things directly related to a full class name, like pseudo states, pseudo elements or media queries
I hope these tips help. Good luck
@vanzasetia
Posted
👋 Greetings, there!
🎉 Congratulations on finishing this challenge! One suggestion, I would recommend having an alternative text for the barcode image, like "QR Code". It's the main content of this page so it's important that all users know about it.
That's it!
@vanzasetia
Posted
One more thing, I notice that you are creating BEE(block__element__element) <section class="main__text__section"> . This is not a valid BEM. I would recommend making it main__text.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
