@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- The
articleelement is being used incorrectly ⚠️ and not needed for this challenge.
- The headings in your component are being used incorrectly❌. Since the
h1heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2heading ✅ since it is reusable and it will give each heading the same level of importance.
- Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The
anchor tagwill achieve this.
More Info:📚
- For improved accessibility 📈 for your content, it is best practice ✅ to use
emformedia-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 👾
Marked as helpful
@Mitko90
Posted
@vcarames Hello and thanks for the feedback. Will update shortly with the suggested changes. I'm really grateful for your comments and I did the mobile first approach because you advised me to do so.
I thought a lot about which heading to use and apparently I chose the bad one. My question though is
If I change my tag to h2, would I get accessibility warnings because last time I did?
Thanks again
@VCarames
Posted
@Mitko90
I’m glad that I been able to help you in your coding journey.
Regarding the heading, unfortunately, yes. This is because the report is not aware that it is a component and not a full website.
But, you can remove the warning by adding a visually-hidden h1 heading to your code.
