Mobile first then coded for dekstop. A simple start

Community feedback

• 

  hardy•3,660

  @hardy333Posted about 3 years ago

  Hi, good job website looks good, but I have few suggestions about css.

  • On body, do not use width: 100vw, instead use width: 100%. As you can see on mobile screen sizes there are horizontal scroll bar, that is only because of 100vw.

  • on body don't use height: 100vh. use min-height: 100vh; instead, min-height is more flexible and responsive then height. In general don't use fixed height property at all.

  • On outer div, on mobile view you don't need display: grid. your content flow is already vertical, if you what to center everything use margin: auto; property.

  Hop those suggestions will help you improve your css. Good luck.

  Marked as helpful

  4
• 

  Juveria Dalvi•1,375

  @Juveria-DalviPosted about 3 years ago

  Hey..😊 So the accessibility issue says you should have <main> tag which is a semantic tag, wrap your all divs inside the main tag except for the div with class attribution that should be wrapped in <footer> tag

  Marked as helpful

  1