Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first sunnyside landing page using html, scss and javascript

@AmazingTool777

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


What html tags and attributes did you use for the responsive images? Did anyone see that the footer color described in the style guides was not quite the same as the one in the previews?

Community feedback

T
Chamu 13,110

@ChamuMutezva

Posted

Greetings ToolTra.

Well done on your first challenge. There are some issues raised in the report , that can be fixed by following the provided links on each raised issue.

Take note also that interactive elements such as buttons and links should have readable text - an image inside an interactive element may not be sufficient to pass the desired message to users if it(image) does not have an alt value. This is in reference to the footer social elements.

For styling classes are usually recommended that id's and in addition nav#navbar .wrapper #navbar-links.show , avoid using declarations such as this one. It will be difficult to debug and maintain. I would assume targeting just .show can be used to get the desired results.

A minor issue , using dev tools - open your site to mobile view, click the nav button and get back to full screen and observe your navigation items. The navigation items will not be displayed as expected (they will be displayed as a column). At the same time , users does not view pages that way - but it can be fixed.

Well done

Marked as helpful

0

@AmazingTool777

Posted

@ChamuMutezva thank you very much for the feedbacks. You addressed major issues that I need to be aware of in my further projects. I appreciate a lot.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord