Mobile First |Stats-preview-card-component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi! 👋

  Good effort on this challenge! 👍

  Before diving into your CSS, there are a couple of things on the HTML that you need to fix/improve.

  • The card is the main content of the page. So, it should not be wrapped by aside element (including the image).
  • The attribution should live outside the main landmark. It should live on its own landmark which is footer landmark.
  • There are two versions of the image-header, the mobile and the desktop version. This is a great situation to use picture element. By using picture element you can tell the browser to show a suitable image for different devices.

  Now, for the CSS.

  • For margin, I recommend using rem unit instead of the percentage unit. rem behaves more consistently than the percentage unit. Unless you make sure everything is okay when you use the percentage unit then it's best to use rem unit.
  • Lastly, the text color for the attribution is not having enough contrast. It is impossible for me to read it. So, my recommendation is to change the color to white.

  Hope this helps.

  Marked as helpful

  1

  ---

  

  scarydeveloper•130

  @snake321Posted over 2 years ago

  @vanzasetia Thanks for your feedback It help me a lot.Thank you so much

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @snake321 No problem! I am happy to know that my feedback helped you. 😉

  1