Mobile First - Stats Preview Card (HTML/CSS3)

Community feedback

• 

  Abhineet Kandele•320

  @abhineetkandelePosted over 3 years ago

  Great Job!!

  Few things I would suggest.

  • Try importing the Font family inside the CSS file itself.
  • Solution can be looked at again for more responsiveness.

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hello

  Scrolling is fine, that's what you want when the content is longer than the screen size

  To center a component on a screen don't use 'magic numbers' with margin. It will only look right for your screen and noone else's! Instead, add a little padding to the wrapper element (eg 1rem to prevent component from ever hitting screen edges), min-height 100vh, and use either flexbox or css grid properties to center it

  To get your image looking more like the design look up css blend modes. I think you want the multiply value

  You also need to adjust line height on this to be more like the design

  0

  ---

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  In the html, you need to change the item spans for meaningful elements. I think list items would be most appropriate for this, so stat would also need changing to be an unordered list.

  Other point is more of a question... Why is the paragraph wrapped in a div? Is that necessary? Remove it if it's not, just like you'd remove any css that isn't necessary

  0