Mobile first Static Github job listings with vanila javascript

Community feedback

• 

  Tom Trung Zacchia•125

  @tomzacchiaPosted about 4 years ago

  Hi Abdulazeez,

  Great work so far. Here are some things that I noticed:

  1. For the language elements, in some cases the text itself is larger than its parent. This is due to the fact that on line 123 of your CSS you have the following: .languages { width: 100px; padding: 5px auto; } The div with className .languages has a fixed width regardless of the text inside of it. I recommend that you removed the width property from this div.

  2. Pay more attention to the smaller details in the design, such as:

  • The job titles are black in the original design
  • There are also tags such as "new" and "featured" that are missing in your application

  Hope this helps, Tom

  0

  ---

  

  Abdulazeez Yusuf•150

  @horler408Posted about 4 years ago

  @tomzacchia Thanks for your suggestions, though I noticed some of these things too especially the 2nd observation and am currently working on them. Any idea on how to use check box to filter the search?

  0

  

  Tom Trung Zacchia•125

  @tomzacchiaPosted about 4 years ago

  @horler408 you can add an event listener to the search on and have a handler function that would do the following:

  1. filter the jobs array based on the search keyword
  2. re-render the jobCards based on the filtered array

  0