Mobile first solution using Grid and Flexbox

Community feedback

• 

  Aleksandr Aksenov•750

  @axevldkPosted almost 4 years ago

  Hi, Carlos T ~ I have studied your work. Good so far. Here are some of my opinions.

  1. You missed > here. <article class="card card3", and it's making serious issues on the page.

  2. Maybe this is missing. .early-access-container::after { left: 0; }, so there is a scrollbar on desktop version. And you can also add overflow-x: hidden to html and body tag.

  3. Some images don't have alt attribute, and email input box doesn't have name attribute. Name field is mandatory for input boxes.

  4. .reviewer-name-info { line-height: 8px; } This is not good. It's making string overlapped on smaller resolutions. You can set line-height as percentage, like 120% or so.

  5. Also there is --> bug at the bottom of the page.

  6. .cards { grid-template-columns: repeat(auto-fit,minmax(400px,1fr)); } makes error on width below 400px. It's not good for responsiveness. You can set it to auto on lower resolution.

  Hope my opinions can help your coding even a bit. Happy coding ~ 😊

  0

  ---

  

  Carlos T•160

  @ctx14Posted almost 4 years ago

  Hey Aleksandr, I really appreciate the feedback. As you can see there's still a lot for me to learn. I will look at your recommendations and will make the necessary adjustments. Again, thanks for thanking the time to review my page!

  0