Mobile First Solution Using Flexbox-CSS and HTML

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey, Dardian! 👋

  Nice job on this challenge! 👏 Your solution looks good and is responsive! 🙌

  I'd like to suggest,

  • Taking a look at your solution report and trying to clear up some of the errors that are there (it looks like you should be using some less-important heading tags, such as <h2> or <h3> for the titles of the sections of the cards).
  • Perhaps not switching to a mobile-friendly layout so soon (since there's still plenty of space for the desktop layout of the card component) and that'll make it so that there's less empty space to the sides of the card when the layout first changes.
  • Also perhaps using anchor tags (rather than the <button> element) for the "Learn More" links in the card (since they seem like they might take the user somewhere when clicked). 😉

  Hope those few tips help. 🙂

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Dardian•60

  @TheTryfechtaPosted over 3 years ago

  @ApplePieGiraffe Thanks for the amazing feedback, I implemented all the suggested changes.

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  well over all it looks close but as the paragraph of text in the cards change it is changing your button alignment you need to put a height on that paragraph so no matter how the text wraps as screen size changes the button staying in the proper location across all the cards. Also you need to work on your hover state for the buttons

  1

  ---

  

  Dardian•60

  @TheTryfechtaPosted over 3 years ago

  @palgramming Good catch. And the image inside the folder was named "active elements" so I put the state on click (:active), but now that I read the description of the challenge it does mention that it should be on hover, so I will change that now. Thanks for the help!

  0