Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile-first solution using css flexbox

@MUFTIATBAKARE

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I need a feedback on another way to go about this project. A shorter code?

Community feedback

Jasper 50

@jaspervo91

Posted

Neat code!

You can use the max-width property to set the maximum width of an element.

The problem with the <main> container and <img> element occurs when the browser window is smaller than the width of the element (320px and 288px respectively). The browser then adds a horizontal scrollbar to the page.

Using max-width instead, will improve the browser's handling of small windows.

For example:

img {
    max-width: 288px; /* or 100% */
    height: auto;
    border-radius: 16px;
}

Marked as helpful

0

@TedJenkler

Posted

Hi @MUFTIATBAKARE,

Nice project! Here are a couple of suggestions to enhance it further:

OG Meta Tags: Consider adding Open Graph (OG) meta tags to your site. This will improve SEO and create visually appealing links when shared on social media, which can help increase visibility.

Clickable QR Code: I recommend making the QR code clickable by either wrapping it in a link or providing a small text link. This will make it easier for older users to access the site without having to scan the code.

Keep up the great work!

Best, Teodor

0

@MUFTIATBAKARE

Posted

Thank you so much for the feedback. This is really helpful.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord