Skip to content
Submitted about 2 months ago

Mobile-first solution using CSS Flexbox

Jaydev Parmar•90
@Jaydev576
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Øystein Håberg•10,390
    @Islandstone89Posted about 2 months ago

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

    • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • "Improve your" is a heading. I would make it a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    CSS:

    • It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.

    • Including a CSS Reset at the top is good practice.

    • Remember to specify a fallback font:font-family: 'Outfit',sans-serif;

    • Remove the margin on body.

    • I would recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

    • Remove the margin on the card.

    • To center the card horizontally and vertically, I would use Flexbox on the body:

    display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100svh;

    • Remove the width on the image.

    • Remove the width on the card - it's rarely a good idea to set fixed sizes, as we need our components to shrink and grow in response to all kinds of different devices.

    • We do want to limit the width of the card, so it doesn't get too wide on larger screens. Give the card a max-width of around 20rem to solve this issue.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container. Remove the margin, though you could give it a margin-bottom.

    • To create the space between the image and the edge of the card, set padding on all 4 sides of the card:padding: 1rem;.

    Marked as helpful
    1
  • guilhermesiqueira13•150
    @guilhermesiqueira13Posted about 2 months ago

    I learned a lot from this challenge, it made me think a lot about things that escape us when we are learning.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord