Mobile first solution using CSS flex and grid

Community feedback

• 

  Ravi Pratap Singh•110

  @cyberspatialPosted about 3 years ago

  Good solution. Few things I want to add

  1. For a Desktop site , you had used flex to center the content, but in the given design it was left aligned so u could use " text-align:left", U can also change using the flex-box if the flex-direction is row, then u can use "justify-content:flex-start", if the flex-direction is column then you can use align-items:flex-start.
  2. You could remove your accessibility issues by changing <div class="card"> to <main class="card"> and changing <div class="attribution"> to < footer class="attribution">

  Marked as helpful

  1
• 

  Ahmed Faisal•5,095

  @afrusselPosted about 3 years ago

  Good work. Nice try. Just playing with height for main container. I would like to request you please take a look of [my solution] (https://afrussel.github.io/stats-preview-card-component-fm/) it may help you to find your issues

  2