Mobile First Solution for QR Code Component

Community feedback

• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi Ankit

  Congrats on completing the challenge.

  I have a few other suggestions which might help you.

  1. Instead of simply using div for containers and sections, you should try and use semantic elements such as main, section, article etc. Read more on them here.
  2. You have used a h2 element for the title , I'd recommend using h1 and then styling it as per need. Since each page needs to have a single h1 which describes the main title and it is not recommended to use headings for styling purposes we have css for that.Read more on headings here.

  Hope it helps, Happy Coding

  Marked as helpful

  0

  ---

  

  Ankit Kumar Thakur•10

  @DrThakurPosted over 1 year ago

  Thanks! @rohitd99 ..I am glad that I could get real time feedback from my peers. I have worked on your suggestions and tried to improve the solution as much as I can. I hope you can take time out to review it too. I promise to keep on improving. Thank you so much:)

  0
• 

  RatifiedGeorge•670

  @RatifiedPosted over 1 year ago

  Hello @DrThakur

  You've actually pretty done a good job

  However, I'd advise centering your card from the body because in this case, the whole card should be at the center. Add this to your body:

  body{ display: grid; justify-content: center; align-items: center; min-height: 100vh; }

  Remove the flex properties from your card-container class. But if you want to keep it, you can also add this to your card-container: card-container{ display: flex; justify-content: center; align-items: center; //this will center your card horizontally, that's what you forgot. }

  Hope this helps.

  Marked as helpful

  0

  ---

  

  Ankit Kumar Thakur•10

  @DrThakurPosted over 1 year ago

  Thanks @Ratified ..I am glad that you took your time out to point out the issue. If I had known that I will get feedback in realtime here, I would have started solving all the challeges a long ago. Thanks for this. I have worked on your suggestions and tried to improvde the solution. I hope you take out some time to review it. Also you will keep providing feedback to all my upcoming solutions. Thank you very very much:)

  0

  

  RatifiedGeorge•670

  @RatifiedPosted over 1 year ago

  @DrThakur,

  I've checked out your improved solution

  You've done well, completely responsive, clean well readable code. Keep up. All the best in your upcoming solutions, I'll try as much as possible to be reviewing them and comment.

  All the best Sir

  0