Mobile first site using sass

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, upon looking the website. The layout hides the text. The height of the container of the text gets small and text are being hidden.

  Removing the height: 60% on the main tag seems to solve the problem.

  Some suggestions would be:

  • Your figure usage on this one is not really ideal. Instead of wrapping a testimonial in a figure, wrap them in a blockquote.
  • The name of a person could be wrapped inside a heading tag like h2 along with their position. Also, it would be great to have your h1 as a screen reader only text. Always have at least 1 h1 per page. On this challenge, h1 as a sr-only would be really great.
  • alt text on the image could be the name of the person
  • Also just a quick tip, a figure element is much more preferable when a content is a figure, image. figcaption is the caption, describing the image.

  Still, you did great on this one.

  Marked as helpful

  0

  ---

  

  Juan David Osorio Ortiz•160

  @JuanDa15Posted about 3 years ago

  @pikamart thank you so much, i will fix that. I appreciate your feedbacks.

  0