Mobile first site using html, css-flexbox.
Design comparison
Solution retrospective
Your constructive criticism will help me to improve my skills.
Community feedback
- @MojtabaMosaviPosted over 3 years ago
1- using relative units such as rem and em make you styles behave more as expected across different divices because they are based on the defualt fontize and they change accordingly. Personaly I use em for media queries and rem for paddings and margins.
2- Try to use descriptive names for you markup, for instance para could be substitued with description. I suggest you spend some time reading about BEM because it makes it easier for you to name stuff amoungst many other benefits.
Keep coding :=)
Marked as helpful2 - @palgrammingPosted over 3 years ago
you should change the
background-size
on your body tag from100%
to100vw 40vh
Marked as helpful1 - @afrusselPosted over 3 years ago
- Using a max-width: 450px; for .card class
- Change image fix height as well
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord