Mobile first site using HTML, CSS, Flexbox, and SASS
Design comparison
Solution retrospective
Hey! Check out my second solution! 😀
I didn't noticed any major mistakes, but if you do, please let me know.
Happy coding! 😁
Community feedback
- @pikapikamartPosted over 3 years ago
Hey, great work on this one. The layout in desktop is fine and the mobile state as well.
Some suggestions would be that:
-
I think you are rendering the wrong font in here, you might want to check that one out.
-
The text-alignment are somewhat not proportional to other. Since for every text-section you are using, you apply
text-align: center
to them which is not really on the design. They need to be on the left side and also, you might want to adjust the width capping. On the original, the text are somehow longer than you are using, so adjusting the width on those will be really good. -
The social media icons on the footer needs to be wrapped inside
a
tags, since they are links right, so nesting them is good. -
Your form on the mobile state, it is on the right side, which I think should not be the case, or am I wrong, I haven't really tackle this one. But check that one out as well. But I am glad that you made another html on the form submission^
But still, really good job on this^
1 -
- @isaacnovaesPosted over 3 years ago
Hello, pikamart!
First of all, thank you for your feedback, I really appreciate it.
Here are my comments on your suggestions:
-
You are totally right because the font rendered was a sans-serif fallback, not the Poppins font. This mistake is already fixed in the new version of the site.
-
For the mobile version, the text alignment should be center. However, for the desktop version, it should be left. I just forgot to make this conversion. Mistake fixed, too.
-
Yep, I agree with you. Mistake fixed.
-
According to the original challenge design, the form inputs should be right-aligned. So I think that my solution is appropriate.
Once again, thank you for your feedback.
I ask you to check the new version of my solution. If you find something else, please let me know.
Happy coding! 😀
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord