Design comparison
Solution retrospective
Where do i will get the original solutions of the challenges?
Community feedback
- @palgrammingPosted over 3 years ago
You should put your main background on the
<body>
tagMarked as helpful1@AnuRoboPosted over 3 years ago@palgramming Yes you are right instead of making a separate container for background work it's better to use
<body>
tag. Can you please tell me how to determine or estimate the parameters of the cards in this challenge? It would be a great help0 - @jmnyaregaPosted over 3 years ago
Hi @AnuRobo, good job on the challenge. I have a few suggestions:
- Avoid setting solid heights, instead of
height: 100vh
usemin-height: 100vh
. - To remove the horizontal scrolling, add
overlow-x: hidden
on the body. - Prefer relative units to px, this allows users to adjust font sizes from their browser settings.
- Wrap your card with the HTML 5 tag
main
.
Happing coding 🙂
Marked as helpful1@AnuRoboPosted over 3 years ago@jmnyarega Thanks for your suggestions as a newbie, I am working on it. Can you please tell me how to determine or estimate the parameters of the cards in this challenge? It would be a great help
0@jmnyaregaPosted over 3 years ago@AnuRobo
- In this case, you can use the
width
of the card image. - Let the content inside the card figure out its height.
- You can use your eyes 🙂 to approximate the padding & margins around the content. But, if you want to be pixel perfect use tools like Figma to measure the
spacing
,widths
&heights
.
That said, don't let perfection be the enemy of good. I would rather you focus on the fundamentals as you are working on these projects. Don't give room for frustrations.
- Layouts (flexbox, grid layout)
- Box model ( width, height, padding, margin, border)
- Typography
All the best.
Marked as helpful0 - Avoid setting solid heights, instead of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord