mobile first site using HTML, BEM and CSS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi David

  On mobile the top of the content is off screen for me and the attribution footer overlaps other content. Definitely address that if you can.

  Usually the problem is explicit heights and/or absolute positioning, neither of which should be necessary for this solution.

  Hope thats helpful

  1

  ---

  

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Also. On mobile landscape all the text becomes centered, which looks a bit strange

  0

  

  David Ouma•270

  @daudi13Posted almost 4 years ago

  @grace-snow thank you let me take a look at those issues.

  0
• 

  Kristian Dunne•305

  @KristianDunnePosted almost 4 years ago

  @daubi13 Your mobile implementation is great but I have a few suggestions that would improve the desktop version.

  • Add more padding to your boxes
  • Increase the font sizes
  • Add a max-width to your .container-box
  • Increase line-height on your list items

  You should also capitalize the sign up button label and remove its opacity when it is not being hovered over.

  Keep up the good work!

  0

  ---

  

  David Ouma•270

  @daudi13Posted almost 4 years ago

  @KristianDunne thank you for taking your time

  0
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hey David 👋 ,Amazing job on this challenge !! Your solution is responsive and I liked your solution very much 👌👌

  ** Just a opinion : ** adding cursor : pointer to "sign up" button can make the user experience a bit better

  Happy Coding 😇 & Keep contributing these AMAZING solutions 🚀

  0

  ---

  

  David Ouma•270

  @daudi13Posted almost 4 years ago

  @abhik-b thank you for pointing that out

  1