Fylo Dark Theme Landing Page | Bootstrap

Community feedback

• 

  P

  j5•2,290

  @jmnyaregaPosted over 3 years ago

  Hi, @jolangker good job on completing the challenge.

  I have a couple of suggestions:

  • Prefer relative units(rem/em) to pixel. em-vs-rem-vs-px

  • You missed adding spacing before header & hero.

  • Hero image should stretch across 100% of the screen's width. I used background property to manage this.

  • The box-shadow on the cards isn't working properly because you did not add the spread.

       {
           box-shadow: 0 0 10px 5px #1c2431; // I added to zeros in front, 
       }
    

  • Add max-width on the text inside Get Early Access Today card. This will prevent the card from stretching too much.

  • On the footer contacts, use mailto & tel links mailto

  Check out my implementation of this challenge, I think you can pick one or two things from there. I could also use some feedback.

  Cheers

  Marked as helpful

  0

  ---

  

  Muhammad Raihan Thaariq•130

  @jolangkerPosted over 3 years ago

  @jmnyarega thanks for your suggestions!

  0