Mobile first site using BEM and media queries

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hi

  This looks OK mobile vertical but breaks on landscape orientation. To fix this you don't need another media query but can refractor your code. Here are some tips

  • font sizes must always be in a responsive unit like rems, not pixels
  • beware using percentages for paddings, margins, widths etc. Depending on the context those values can change a lot
  • only place widths and heights on elements that really need them. Always think - would a min- or max- do the job instead?

  That should help to start with. Good luck, and well done so far

  2

  ---

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Ps one more thing - the learn more buttons should actually be anchor tags as they would be used for navigation

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  You need to check your Media Query your page switches from vertical to horizontal and back again. As well before your your vertical layout transitions to the horizontal it is too wide and needs to be contained before transition

  1

  ---

  

  Alexander•200

  @IcEWaRRiOr01Posted over 3 years ago

  @palgramming thanks for the feedback. And how to do it?

  0