Mobile first site built with HTML and CSS.

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Awesome work on this challenge, Beattris! 👍 Here are a couple of pointers after taking a look at your code:

  • I would recommend avoiding IDs for styling. They're very specific and they can't be reused on the page. Instead, I'd stick to class, attribute, pseudo, and type selectors. This will help your code be more maintainable, especially in larger projects.
  • The curved images are purely decorative, so I'd recommend using background-image in your CSS, instead of img in your HTML. You could use a pseudo-element, like ::before in your CSS to add the detail on the top of the section. This would clean up your HTML and make sure that this content is hidden to screen reader users.

  Let me know if you have any questions. Keep up the great work! 🙂

  1

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Also, I'd recommend having a go at removing the accessibility errors in the report 👍

  1

  

  beattris•65

  @beattrisPosted almost 5 years ago

  @mattstuddert I think I'll have to learn CSS pseudo elements, I don't know how it works. Also, I'll try to get rid of the accessibility errors. Thanks for the pointers!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @beattris you're welcome! Here's a great CSS Tricks article about pseudo-elements to get you started.

  1

  

  beattris•65

  @beattrisPosted almost 5 years ago

  @mattstuddert Thank you for this article!

  0