Mobile first site, bootstrap media queries, no mid section, old design
Design comparison
Solution retrospective
Hello, I would kindly ask you if you could give me feedback, I think I wasted to much with changing paddings and margins in media queries using em units, how should I avoid it or what is the proper way to position elements? I think my way is wrong :/
Community feedback
- @adarshcodesPosted over 4 years ago
Hey @janez33, your solution looks great. But it is completely different from the screenshot, but the design is present in your design folder is the same one which you work (maybe the site issue).
- Your solution looks really great.
- Responsiveness works fine.
- I think you use margin and padding where it is required so no problem for this.
- Solve the HTML and Accessibility issues
Keep Coding :)
2@janez33Posted over 4 years ago@adarshcodes
Thank you very much 😊 oh yeah forgot to check the report, will do it tomorrow.
About my design, I did this more than 1 year ago, and they updated design for this particular landing page so I just uploaded my old version.
1 - @InterplanetaryDragonPosted over 4 years ago
Hi Janez, I'm going to attempt this solution tomorrow. I've been practising with CSS grid and Flexbox. Regarding setting margins and padding for different scree, you could instead try setting a % as this scales automatically. I've found it useful. For example body {margin: auto; padding: 5%;} the margin centres the body which helps on my screen (most of these challenges use a max body of 1440px and my screen is around 2200px). The padding creates a nice buffer around the entire screen which is very useful on some designs. You can also use the % for divs. For example, div-name {margin: 5%; padding: 2.5%}.
0@janez33Posted over 4 years ago@InterplanetaryDragon Cool, thank you very much, will use this approach in my next project🙂
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord