Mobile first site a focus on semantic HTML

Community feedback

• 

  Miquel•275

  @mrjayy5Posted about 4 years ago

  Hi Dean, great job! It's even a match without PixelPerfect 👏🏼!

  Your HTML is semantic almost perfect. The only suggestion I have is that you use h3 before h2. I made this mistake myself sometimes!

  Also there is still a little bit of redundant code. You might find this usefull:

  <header class="singleprice__header">
                <h2>Monthly Subscription</h2>
  </header>
  <header class="singleprice__header">
                <h1>Join our community</h1>
                <h2 class="yellow">30-day, hassle-free money back guarantee</h2>
  </header>
  
  .singleprice__header {
                h1 {
                              ...
                }
                h2 {
                              ...
                              &.yellow {
                                            ...
                              }
                }
  }
  

  Nevertheless, great work! Keep on coding 🔥!

  2

  ---

  

  Dean Hope•230

  @deanhopesPosted about 4 years ago

  This makes total sense and I'll definitely be using this from now on!

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Yup! Nice job, Dean Hope! 🙌

  Simply implement Brasspetals' helpful suggestion and you should be good to go! 👍

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Dean Hope•230

  @deanhopesPosted about 4 years ago

  Thanks ApplePieGiraffe :)

  0
• 

  Anna Leigh•5,135

  @brasspetalsPosted about 4 years ago

  Excellent job, Dean! It responds nicely and matches the design well. My suggestion would be to add cursor: pointer to the button and maybe some :hover and :active states for more interactivity.

  1

  ---

  

  Dean Hope•230

  @deanhopesPosted about 4 years ago

  I'll do this for my next challenge, thank you :)

  0